x86 hvm: Do not overwrite boot-cpu capability data on VMX/SVM startup.
authorKeir Fraser <keir@xen.org>
Tue, 30 Nov 2010 11:34:08 +0000 (11:34 +0000)
committerKeir Fraser <keir@xen.org>
Tue, 30 Nov 2010 11:34:08 +0000 (11:34 +0000)
commit4a380f72ba251011c35216ab7a6f6918b5d0485e
tree2775eb1e6bfab74a2f73723e3d900e658399bac8
parent9e1a3415b773fab5ec57f0f9e972df9881090bfb
x86 hvm: Do not overwrite boot-cpu capability data on VMX/SVM startup.

Apparently required back in the earliest days of Xen, we now properly
initialise CPU capabilities early during bootstrap. Re-writing
capability data later now causes problems if specific features have
been deliberately masked out.

Thanks to Weidong Han at Intel for finding such a bug where XSAVE
feature is masked out by default, but then erroneously written back
during VMX initialisation. This would cause memory corruption problems
during boot for XSAVE-capable systems.

Signed-off-by: Keir Fraser <keir@xen.org>
xen/arch/x86/hvm/svm/svm.c
xen/arch/x86/hvm/vmx/vmx.c